display: pick gl=off on Windows where virglrenderer is unavailable#65
Open
AngelBob wants to merge 1 commit into
Open
display: pick gl=off on Windows where virglrenderer is unavailable#65AngelBob wants to merge 1 commit into
AngelBob wants to merge 1 commit into
Conversation
Change depends on landing libqemu/v11.0 MR !1571 first. On Windows-on-ARM, libqemu is built without virglrenderer because msys2 clangarm64 does not ship it. Requesting "sdl,gl=on" segfaults at SDL/EGL init since the GL path cannot establish a virgl-backed context. Pick "sdl,gl=off" on _WIN32 and "sdl,gl=on" elsewhere. The 2D path in libqemu requires a companion fix to ui/sdl2 so that sdl2_2d_switch creates the SDL_Renderer after dpy_window_create; without that fix the SDL window opens but never paints. Also log the chosen backend at INFO so it is visible at default verbosity. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Steve Aarnio <saarnio@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change depends on landing libqemu/v11.0 MR !1571 first.
On Windows-on-ARM, libqemu is built without virglrenderer because
msys2 clangarm64 does not ship it. Requesting "sdl,gl=on" segfaults
at SDL/EGL init since the GL path cannot establish a virgl-backed
context.
Pick "sdl,gl=off" on _WIN32 and "sdl,gl=on" elsewhere. The 2D path
in libqemu requires a companion fix to ui/sdl2 so that sdl2_2d_switch
creates the SDL_Renderer after dpy_window_create; without that fix
the SDL window opens but never paints.
Also log the chosen backend at INFO so it is visible at default
verbosity.
Co-Authored-By: Claude noreply@anthropic.com
Signed-off-by: Steve Aarnio saarnio@qti.qualcomm.com