Skip to content

Add pytest-instafail package#1402

Draft
mhucka wants to merge 6 commits into
quantumlib:mainfrom
mhucka:add-pytest-instafail
Draft

Add pytest-instafail package#1402
mhucka wants to merge 6 commits into
quantumlib:mainfrom
mhucka:add-pytest-instafail

Conversation

@mhucka

@mhucka mhucka commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

This adds the package pytest-instafail to the requirements for the development environment, so that we can inform people how to use the --instafail to learn about failures immediately. The built-in pytest option -x and --instafail work in complementary fashion: pytest -x makes it stop on first failure (and subsequent tests are not executed); pytest --instafail makes it print failures immediately, but continue execution.

Along with that, this PR adds more helpful test info to CONTRIBUTING.md.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the functional testing documentation in CONTRIBUTING.md with additional pytest options and adds the pytest-instafail dependency to the development environment files. Feedback indicates that pytest-max-compat.env.txt was compiled without the correct constraint file, leading to a noisy diff where constraint references were removed. Recompiling this requirements file with the proper constraint settings is recommended to maintain a clean change history.

# via
# -c dev_tools/requirements/max_compat/dev.env.txt
# tensorflow-docs
# via tensorflow-docs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The compilation of pytest-max-compat.env.txt appears to have been run without the constraint file -c dev_tools/requirements/max_compat/dev.env.txt. This has resulted in a massive, noisy diff where the constraint references are removed from the # via comments of almost all packages.

Please recompile this requirements file using the correct constraint file to keep the settings functionally equivalent to the original and maintain a clean change history.

    # via
    #   -c dev_tools/requirements/max_compat/dev.env.txt
    #   tensorflow-docs
References
  1. When migrating configuration, keep the settings functionally equivalent to the original to maintain a clean change history. Address known issues in the configuration in a separate change.

@mhucka mhucka marked this pull request as draft July 9, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant