Block insecure HTTP URLs in FileUtil by default#1247
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
Copilot created this pull request from a session on behalf of
chrjohn
June 2, 2026 15:56
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileUtil.open()would silently fetch resources (including DataDictionaries) over plain HTTP, exposing the load path to MITM substitution attacks. SinceDataDictionaryis the primary consumer, a compromised dictionary could bypass all message validation.Changes
FileUtil: Before opening anyhttp://URL, checks system propertyquickfixj.fileutil.allowHttpUrls. If nottrue(default), logs aWARNand returnsnull— the caller will fail with a descriptive "could not find" error. Iftrue, loads but still warns.https://,file:,jar:, and classpath locations are unaffected.FileUtilTest: UpdatedtestURLLocationto assert HTTP is blocked by default; addedtestHTTPUrlAllowedViaSystemPropertyfor the opt-in path.Opt-in override
For deployments on trusted private networks that genuinely need plain HTTP: