Skip to content

Remove unused dependencies from quickfixj-base#1252

Merged
chrjohn merged 2 commits into
masterfrom
copilot/check-unheeded-dependencies
Jun 6, 2026
Merged

Remove unused dependencies from quickfixj-base#1252
chrjohn merged 2 commits into
masterfrom
copilot/check-unheeded-dependencies

Conversation

Copilot AI commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Maven dependency analysis identified unused and incorrectly scoped dependencies in quickfixj-base.

Changes

  • Removed mockito-core - No usage found in test sources
  • Removed hamcrest:3.0 - Redundant explicit dependency; hamcrest-core:1.3 already available transitively via junit:4.13.2
  • Fixed slf4j-api scope - Changed from compile to test (only used in FileUtilTest)

Before

<dependency>
    <groupId>org.mockito</groupId>
    <artifactId>mockito-core</artifactId>
    <scope>test</scope>
</dependency>
<dependency>
    <groupId>org.hamcrest</groupId>
    <artifactId>hamcrest</artifactId>
    <scope>test</scope>
</dependency>
<dependency>
    <groupId>org.slf4j</groupId>
    <artifactId>slf4j-api</artifactId>
    <version>${slf4j.version}</version>
</dependency>

After

<dependency>
    <groupId>org.slf4j</groupId>
    <artifactId>slf4j-api</artifactId>
    <version>${slf4j.version}</version>
    <scope>test</scope>
</dependency>

junit-vintage-engine retained - required for JUnit 4 test execution under JUnit 5.

@chrjohn

chrjohn commented Jun 6, 2026

Copy link
Copy Markdown
Member

@copilot FileUtilTest.testFileLocation:40 NullPointer

Copilot AI commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

@copilot FileUtilTest.testFileLocation:40 NullPointer

Fixed in a293d3f. The test was checking for null after closing the stream. Also corrected the LICENSE path to "../LICENSE" since Maven runs tests from the module directory.

@chrjohn chrjohn marked this pull request as ready for review June 6, 2026 16:13
@chrjohn chrjohn added this to the QFJ 3.0.2 milestone Jun 6, 2026
@chrjohn chrjohn merged commit 4329f43 into master Jun 6, 2026
23 checks passed
@chrjohn chrjohn deleted the copilot/check-unheeded-dependencies branch June 6, 2026 16:13
@chrjohn chrjohn changed the title Remove unused dependencies from quickfixj-base Remove unused dependencies from quickfixj-base Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants