Only export API symbols for shared builds#1525
Open
dannote wants to merge 1 commit into
Open
Conversation
saghul
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #940.
Public API symbols currently get default visibility on GNU-like compilers whenever
QUICKJS_NG_CC_GNULIKEis defined. For static/vendored builds, that can bypass an embedder’s-fvisibility=hiddensetup and export QuickJS symbols from the embedding shared object.Gate default visibility on the build modes that actually need exported symbols:
JS_EXTERN:BUILDING_QJS_SHAREDJS_MODULE_EXTERN:QUICKJS_NG_MODULE_BUILDWindows import/export handling is unchanged.
Tested: