wayland/background-effect: add ext-background-effect-v1 (blur region)#566
wayland/background-effect: add ext-background-effect-v1 (blur region)#566outfoxxed merged 2 commits intoquickshell-mirror:masterfrom
Conversation
|
For consistency with existing interfaces, this should probably be an attached object. See HyprlandWindow for an example. Do we have any options for blur opacity exposed? |
Changed it to an attached object, the only downside I guess is my thought was getting a BackgroundEffect.active to tell if the compositor had applied it/supported it
That's not exposed by the protocol, its just |
outfoxxed
left a comment
There was a problem hiding this comment.
Rather disappointed in the protocol itself but the implementation is mostly there.
|
Added missing controls to the tester and noticed the corner radius is entirely unclamped at this point so it will break if you take it out of bounds. It should clamp at the point where its bounded by the size of the rect or space used by other corners |
…contribution walkthrough Analysis of upstream PRs quickshell-mirror#566 and quickshell-mirror#351 to understand outfoxxed's review patterns. Comprehensive quickshell style guide derived from codebase analysis. Step-by-step walkthrough for contributing fixes to PR quickshell-mirror#351 (WebEngine support). Key conclusion: no code fork needed — upstream PR quickshell-mirror#351 + spec flag is sufficient. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Added the clamping to region |
ca90821 to
3cf65af
Compare
|
It seems like we're still getting intersections from circles in opposite corners |
I changed the approach again, to cut the corners out of the rectangle. All the scenarios I tried in the tester seem to work for me |
f11b8a4 to
6a244c3
Compare
|
Modified to use ext-bg-effect from w-p and split commits. Will merge once CI passes. |
…contribution walkthrough Analysis of upstream PRs quickshell-mirror#566 and quickshell-mirror#351 to understand outfoxxed's review patterns. Comprehensive quickshell style guide derived from codebase analysis. Step-by-step walkthrough for contributing fixes to PR quickshell-mirror#351 (WebEngine support). Key conclusion: no code fork needed — upstream PR quickshell-mirror#351 + spec flag is sufficient. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>


core/region: add radius to create rounded regions
Adds
BackgroundEffectthat allows setting blur region on layer shell surfaces, additionally adds a radius option toRegionsimilar to the vicinae pattern for making approximate rounded regions.To test on a supported compositor:
qs -p src/wayland/background_effect/test/manual/background_effect.qmlUsage is as: