improve s3 retry log#6609
Open
PSeitz wants to merge 1 commit into
Open
Conversation
fulmicoton
reviewed
Jul 16, 2026
| E: Retryable + Debug + 'static, | ||
| { | ||
| retry_with_mockable_sleep(retry_params, f, TokioSleep).await | ||
| retry_with_mockable_sleep(retry_params, request_name, f, TokioSleep).await |
Collaborator
There was a problem hiding this comment.
are there cases where we don't know which method had a problem?
I thought it was mostly:
searcher -> GET
indexer -> PUT
Collaborator
Author
There was a problem hiding this comment.
for search it should be GET, for indexing is should be PUT, for merge it could be either. But would be good to be sure from the logs
Collaborator
Author
There was a problem hiding this comment.
The log currently just logs request failed, without more context you don't know it's S3
Collaborator
|
The extract context is useless. The caller is logging an error already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.