fix(mobile): correct terminal link extraction edge cases#8
Merged
Conversation
Address review findings from the accidental upstream PR (pingdotgg#4549): - Never join an adjacent URL onto a wrapped one: a continuation line that starts its own http(s) scheme is a separate link, not a wrap continuation of the previous line. - Rank OSC 8 hyperlinks by buffer position instead of prepending them, so a recent OSC link is no longer dropped by the 3-result cap when older plain-text URLs exist. - Replace prefix dedup (which hid distinct URLs like .../repo next to .../repo-utils) with \r-overwrite resolution: keep only the final paint of a line, which removes spinner-truncated intermediates at the source.
r4iju
added a commit
that referenced
this pull request
Jul 26, 2026
…k chips (#10) Updates the exit-path register now that the pingdotgg#4549 review findings are fixed (#8): the terminal link chips delta is code-ready, blocked only on device verification media. Captures the full remaining path — issue-first framing as mobile parity with web link handling, the exact seven-file trimmed diff to cherry-pick from upstream/main, and what the PR body must disclose (native alternative, heuristic limits, candid pingdotgg#4549 reference) — so the contribution can be picked up cold another day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three real bugs flagged by automated review on the accidental upstream PR (pingdotgg#4549) in the terminal link chip extraction:
http(s)://scheme is now treated as a separate link, never glued onto the previous wrapped URL.\r-overwrite resolution (keep only the final paint of a line), which removes spinner-truncated intermediates at the source without suppressing e.g.…/reponext to…/repo-utils.3 new regression tests; 16 total pass, typecheck and lint clean.
🤖 Generated with Claude Code