test malformed-stack reverts in flow() and stackToFlow()#444
Conversation
Pins the documented "MAY revert if malformed" / "MUST revert if malformed" clauses on `IFlowV5.stackToFlow` and `IFlowV5.flow`. The observable revert is `MissingSentinel(RAIN_FLOW_SENTINEL)` from `LibStackSentinel.consumeSentinelTuples` when any of the three required sentinels is absent. Five tests: - stackToFlow on an empty stack - stackToFlow with only one sentinel - stackToFlow with only two sentinels - flow() with an empty evaluated stack - flow() with only one sentinel in the evaluated stack Closes #316 #317 #328. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Pins the documented "MAY revert if malformed" / "MUST revert if malformed" clauses on
IFlowV5.stackToFlowandIFlowV5.flow. The observable revert isMissingSentinel(RAIN_FLOW_SENTINEL)fromLibStackSentinel.consumeSentinelTupleswhen any of the three required sentinels is absent.Five tests:
testStackToFlowRevertsOnEmptyStacktestStackToFlowRevertsOnOneSentinelOnlytestStackToFlowRevertsOnTwoSentinelsOnlytestFlowRevertsOnEmptyEvaluatedStack(fuzzed)testFlowRevertsOnOneSentinelOnlyEvaluatedStack(fuzzed)Closes #316 #317 #328.
Test plan
🤖 Generated with Claude Code