rewrite test src/ imports to relative paths#452
Open
thedavidmeister wants to merge 1 commit intomainfrom
Open
Conversation
Bare `src/` imports break when this repo is consumed as a Foundry git submodule — `src/` resolves to the parent project's source directory, not this submodule's. Every test import now uses a relative path appropriate to its file's depth. Closes #411. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (14)
WalkthroughThis PR updates import paths across 13 test files from bare ChangesImport Path Corrections
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bare
src/imports break when this repo is consumed as a Foundry git submodule —src/resolves to the parent project's source directory, not this submodule's. Every test import now uses a relative path appropriate to its file's depth (../../src/...,../../../src/..., or../../../../src/...).14 test files updated, 19 imports rewritten.
Closes #411.
Test plan
forge buildclean (114 files compile)rainix-sol-test— 31/31🤖 Generated with Claude Code
Summary by CodeRabbit