move BadMinStackLength to ErrFlow.sol#454
Conversation
Every other error reverted from Flow.sol is declared in a dedicated error file (ErrFlow.sol or rain.factory's ICloneableV2.sol). BadMinStackLength was the only outlier. Moving it to ErrFlow.sol lets consumers (interfaces, ABI bindings, integrators) get the selector without importing the concrete Flow contract and its OZ Multicall / ReentrancyGuard / interpreter dependencies. Closes #414. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Every other error reverted from
Flow.solis declared in a dedicated error file (ErrFlow.solorrain.factory'sICloneableV2.sol).BadMinStackLengthwas the only outlier — declared inline in the implementation file.Moved to
src/error/ErrFlow.solso consumers (interfaces, ABI bindings, integrators) can get the selector without importing the concreteFlowcontract and its OZMulticall/ReentrancyGuard/ interpreter dependencies.Closes #414.
Test plan
forge buildclean🤖 Generated with Claude Code