Skip to content

move BadMinStackLength to ErrFlow.sol#454

Open
thedavidmeister wants to merge 1 commit intomainfrom
2026-05-06-issue-414-badminstacklength-relocate
Open

move BadMinStackLength to ErrFlow.sol#454
thedavidmeister wants to merge 1 commit intomainfrom
2026-05-06-issue-414-badminstacklength-relocate

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Summary

Every other error reverted from Flow.sol is declared in a dedicated error file (ErrFlow.sol or rain.factory's ICloneableV2.sol). BadMinStackLength was the only outlier — declared inline in the implementation file.

Moved to src/error/ErrFlow.sol so consumers (interfaces, ABI bindings, integrators) can get the selector without importing the concrete Flow contract and its OZ Multicall / ReentrancyGuard / interpreter dependencies.

Closes #414.

Test plan

  • forge build clean

🤖 Generated with Claude Code

Every other error reverted from Flow.sol is declared in a dedicated
error file (ErrFlow.sol or rain.factory's ICloneableV2.sol).
BadMinStackLength was the only outlier. Moving it to ErrFlow.sol lets
consumers (interfaces, ABI bindings, integrators) get the selector
without importing the concrete Flow contract and its OZ Multicall /
ReentrancyGuard / interpreter dependencies.

Closes #414.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 19 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 780cb0da-68bb-4da4-ab99-72e6eaf6874e

📥 Commits

Reviewing files that changed from the base of the PR and between ceaea3c and 3fd7294.

📒 Files selected for processing (2)
  • src/concrete/Flow.sol
  • src/error/ErrFlow.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-06-issue-414-badminstacklength-relocate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A01-9] [LOW] BadMinStackLength declared in Flow.sol instead of ErrFlow.sol

1 participant