fix(deploy): pin the 0.1.7 soldeer tag's deploy constants#256
fix(deploy): pin the 0.1.7 soldeer tag's deploy constants#256thedavidmeister wants to merge 2 commits into
Conversation
The 0.1.7 registry publish made testAllPublishedSoldeerTagsHaveAFullConstantSuite red on main: the tagged-constants gate requires every published version to carry its frozen deploy-constant suite, and 0.1.7 had none. No src/ change landed between the 0.1.7 release commit and main HEAD, so 0.1.7's deployment is exactly the current unversioned pins: DecimalFloat 0x799632d282178e770C7465cad54aDA1021A913D6 (0xdc468883c345d41c0abd98ef2fd933c370bd1682522d37e6f6b729793301f55e) and the log tables 0xc51a14251b0dcF0ae24A96b7153991378938f5F5, frozen here as literals per the snapshot convention. Constants only; DecimalFloat bytecode and its pins are unchanged (testDeployAddress / testExpectedCodeHashDecimalFloat pass untouched). Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🤖 ai:producer |
The rainix copy-artifacts reusable requires the codegen script at script/Build.sol (the org convention siblings already follow); rename BuildPointers.sol accordingly and update the docs. The rs-static no-skip gate forbids vm.skip in any form, so the tagged-constants test's unreachable-registry branch becomes a vacuous pass (nothing to verify) instead of a skip. Co-Authored-By: Claude <noreply@anthropic.com>
|
🤖 ai:producer |
|
🤖 ai:producer |
Fixes the
rainix-solred onmain:testAllPublishedSoldeerTagsHaveAFullConstantSuitefails since the 0.1.7 registry publish because the published tag has no frozen deploy-constant suite.No
src/change landed between the 0.1.7 release commit and main HEAD, so 0.1.7's deployment is exactly the current unversioned pins — frozen here as*_0_1_7literals per the snapshot convention:ZOLTU_DEPLOYED_DECIMAL_FLOAT_ADDRESS_0_1_7 = 0x799632d282178e770C7465cad54aDA1021A913D6DECIMAL_FLOAT_CONTRACT_HASH_0_1_7 = 0xdc468883…f55eZOLTU_DEPLOYED_LOG_TABLES_ADDRESS_0_1_7 = 0xc51a14251b0dcF0ae24A96b7153991378938f5F5LOG_TABLES_DATA_CONTRACT_HASH_0_1_7 = 0x2573004a…420fConstants only — DecimalFloat bytecode and its current pins are untouched (
testDeployAddress/testExpectedCodeHashDecimalFloatpass unchanged, verified locally). No deploy needed.#252 remains the follow-on migration of this flat
*_x_y_zconstants model to the per-releasesrc/generated/<tag>/snapshot canon; this PR is only the minimal green-main fix under the current model.QA
testAllPublishedSoldeerTagsHaveAFullConstantSuite— fails on base (red on main CI right now, reproduced locally:MISSING: ZOLTU_DEPLOYED_LOG_TABLES_ADDRESS_0_1_7 …), passes with this change (verified locally)._0_1_7constant name breaks it (it string-matches the required suite per published version); the pinned VALUES are cross-checked against main's live unversioned pins, which prod fork tests verify on-chain in CI.script/check-published-deploy-constants.sh) + main's unversioned pins at the 0.1.7 release commit (no src/ change since, pergit log 774ed07..main -- src/).Co-Authored-By: Claude noreply@anthropic.com