Skip to content

S3UploadStream: Cleanup redundant volatile and disposal logic #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rameel merged 2 commits into from
Apr 1, 2026
Merged

S3UploadStream: Cleanup redundant volatile and disposal logic #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
459f96d
Call base.Dispose(disposing)
rameel Apr 1, 2026
f036b51
Remove unnecessary volatile modifier
rameel Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Ramstack.FileSystem.Amazon/S3UploadStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ internal sealed class S3UploadStream : Stream
private readonly FileStream _stream;
private readonly List<PartETag> _partETags;

private volatile int _disposed;
private int _disposed;

/// <inheritdoc />
public override bool CanRead => false;
Expand Down Expand Up @@ -157,6 +157,8 @@ protected override void Dispose(bool disposing)
using var scope = NullSynchronizationContext.CreateScope();
DisposeAsync().AsTask().Wait();
}

base.Dispose(disposing);
}

/// <inheritdoc />
Expand Down
Loading