drm/panel: st7701: Add missing bus_flags configuration for HyperPixel2.1 Round#7298
drm/panel: st7701: Add missing bus_flags configuration for HyperPixel2.1 Round#7298Akkiesoft wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
Conversation
| @@ -713,6 +715,9 @@ static int st7701_get_modes(struct drm_panel *panel, | |||
| */ | |||
| drm_connector_set_panel_orientation(connector, st7701->orientation); | |||
|
|
|||
| if (st7701->desc->bus_flags) | |||
There was a problem hiding this comment.
Why is this assignment conditional? And why is it not done earlier at the point you currently initialise it to zero?
There was a problem hiding this comment.
I simply copied the implementation used in kernel 6.6, I don’t know why that was the case.
https://github.com/raspberrypi/linux/blame/rpi-6.6.y/drivers/gpu/drm/panel/panel-sitronix-st7701.c#L720
I thought this was to account for displays where bus_flags is not specified.
However, when I asked the AI, it seems that since bus_flags is automatically set to 0 when the structure is initialised, line 719 alone should suffice.
Is that correct?
There was a problem hiding this comment.
I have updated the code.
Akkiesoft
force-pushed
the
st7701_bus_flags
branch
from
65fa56b to
b2a6e86
Compare
… 2.1 Round When porting the code for the Pimoroni HyperPixel 2.1 Round from Linux 6.6 to Linux 6.12, the bus_flags configuration was overlooked. Porting bus_flags resolves the noise issues that were occurring. Signed-off-by: Akira Ouchi <akkiesoft@marokun.net>
Akkiesoft
force-pushed
the
st7701_bus_flags
branch
from
b2a6e86 to
2fec573
Compare
|
I'm happy with that if it works for you. |
|
That works for me. |
2 participants
Fix #7194.
Porting the bus_flags configuration from the kernel 6.6 code resolves the noise issue that was occurring with the Pimoroni HyperPixel 2.1 Round.