-
Notifications
You must be signed in to change notification settings - Fork 13
fix: design-system audit — motion, interaction states, focus & accessibility #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ravisuhag
wants to merge
61
commits into
main
Choose a base branch
from
design-audit-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
b85317e
fix: consolidate motion and interaction tokens
ravisuhag 28eedbd
fix: retune the type ramp tracking and leading
ravisuhag e8c1165
fix: table and data-table stylesheet states
ravisuhag fa12492
fix(spinner): speed the loop up from 1.2s to 0.9s
ravisuhag 9fb79c3
fix(floating-actions): margin-based centering, fade+rise entrance
ravisuhag d49074e
fix: guard Image's fallback re-entry, fade in loaded images/avatars
ravisuhag 8d37501
fix: scope Headline's width:100% to the truncate variant
ravisuhag f5aa134
feat: give the announcement bar action button interactive states
ravisuhag 4fa7ae4
fix: tabs standalone/plain variants glide their indicator instead of …
ravisuhag 7b65eea
fix: ease the breadcrumb link hover
ravisuhag 0508388
fix: align popover shadow depth with its surface size
ravisuhag d585271
fix: side-panel overflow:auto, document as persistent layout
ravisuhag 57d106f
fix: give the scroll-area thumb a hover grow and grabbed state
ravisuhag 2832db3
fix: scope preview-card inset/size transitions to viewport-morph mode
ravisuhag acdd909
fix: reveal sticky-header hairlines only once content scrolls under them
ravisuhag a011f19
fix: unify calendar day-cell radius, cross-fade the loading skeleton
ravisuhag 8407860
fix: link hover reveals an underline instead of dimming the text
ravisuhag 16a7831
fix: default Amount to tabular numerals
ravisuhag ff8969c
fix: fade the code-block copy button reveal at the fast tier
ravisuhag 96e9ee9
fix: style selected/pressed rows, add row-state hooks to Table primitive
ravisuhag 6f7701e
fix: distinguish toggle hover from pressed, animate content, fix disa…
ravisuhag 684eade
fix: select popup background and multi-select indicator
ravisuhag c1309e8
fix: render clickable chips as real buttons
ravisuhag dcaaa30
fix: cross-fade the Field error and surface the DatePicker error
ravisuhag 1409722
fix: color-picker area thumb uses transform, blocks touch scroll, fad…
ravisuhag 1915309
fix: let sidebar collapse fade labels instead of popping them
ravisuhag 3637c09
fix: animate callout enter and dismiss (fade + height collapse)
ravisuhag 3759c5d
fix: rewrite tooltip motion as interruptible, symmetric transitions
ravisuhag 64eba23
fix: reduced-motion and reduced-transparency fallbacks
ravisuhag ba6e47d
fix: drawer tracks swipes 1:1, tokenize exit duration, fade under red…
ravisuhag 53b494c
fix: give number-field input real hover/focus/invalid states
ravisuhag 535e1c8
fix: animate indeterminate Progress, move fills to transform: scaleX
ravisuhag a407470
fix: invalid toolbar background value, misnamed text decoration class
ravisuhag 165da45
fix: size the data-view sort icon and flip it on sort direction
ravisuhag d2706f1
fix: stop CopyButton timer leak, cross-fade icon swap, announce state
ravisuhag 5ee2c43
fix: add missing :focus-visible indicators across the library
ravisuhag 089d06c
fix: compose motion tokens into --rs-transition-interactive, add pres…
ravisuhag b16de9f
fix: bring component motion in line with animation standards
ravisuhag 1e7e7aa
fix: static caret on select and combobox triggers, tidy command overlay
ravisuhag 5d66454
chore: drop unused eslint and np release config
ravisuhag 91bb918
test: register CaretSortIcon in the code-block icon mock
ravisuhag 8cfee06
chore: prune dead CSS, gate stray motion for reduced-motion, refresh …
ravisuhag 2bbe90a
fix: dark contrast text on mint accent since mint-9/10 are light
ravisuhag f2862e4
fix: balance heading wrap, load full JetBrains Mono weights, drop fon…
ravisuhag 0c7ac31
fix: make theme switcher keyboard accessible
ravisuhag b46ce33
fix: add keyboard support to color picker area
ravisuhag 8ba340f
fix: make clickable data-view rows keyboard accessible
ravisuhag ae337cf
fix: add missing focus rings to calendar and sidebar
ravisuhag 230a3be
fix: use theme tokens for input text and placeholder
ravisuhag 1948b2c
fix: refine button press states and focus rings
ravisuhag 688ef36
fix: add missing press scale to icon button
ravisuhag 862ddd0
fix: add hairline media edge to image, avatar and code block
ravisuhag 4ec6ef8
fix: float drawer panel and reuse icon button for its close
ravisuhag 4800b1b
fix: align popup shadows to one elevation tier and hairline borders
ravisuhag f5c60cc
fix: snap sidebar nav-item highlight, ease the accordion trigger
ravisuhag e55e41f
fix: add press scale to announcement action and filter chip remove
ravisuhag 02a2b05
fix: fade search clear button instead of display toggle
ravisuhag 0bcb04a
fix: use the real Checkbox as the select multi-select indicator
ravisuhag eb6b8d8
fix: square up the code-block floating copy icon
ravisuhag 760c6e5
fix: hide the DatePicker reserved error line inside filter chips
ravisuhag 1b65cc2
fix: shake the OTP field once on invalid state
ravisuhag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| .amount { | ||
| font-variant-numeric: tabular-nums; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Clarify the
git pullcommand for release candidate branches.Line 228 shows
git pull origin mainwith a comment "or the release branch", but if a maintainer is onrelease/x.y, running this command as-is would mergemaininto the release branch. The command should explicitly show the release branch variant to avoid accidental cross-branch merges.📝 Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents