Skip to content

feat(admin-ui): unify page header height and surface icon prop on Views#1606

Open
paanSinghCoder wants to merge 1 commit into
chore/sdk-admin-apsara-v1from
feat/admin-page-header-icon-and-height
Open

feat(admin-ui): unify page header height and surface icon prop on Views#1606
paanSinghCoder wants to merge 1 commit into
chore/sdk-admin-apsara-v1from
feat/admin-page-header-icon-and-height

Conversation

@paanSinghCoder
Copy link
Copy Markdown
Contributor

Two small follow-ups to the Apsara v1 migration:

1. Header height parity

  • Added `min-height: var(--rs-space-12)` (56px) to the four list-page navbars (orgs/users/audit-logs/invoices) and to `` itself.
  • Roles/Products/Plans/Webhooks already rendered ≥56px due to their Search/Button content; this is a floor.
  • Preferences/Admins previously rendered ~52px (no children); now match 56px.

2. Icon prop on Views

  • Added `icon?: ReactNode` to `RolesView`, `ProductsView`, `PlansView`, `WebhooksView`, `PreferencesView`, `AdminsView`.
  • Each View threads it through to its header / `` and renders next to the title.
  • Each host page imports its sidebar SVG and passes it down, so sidebar and page-header share the same icon source.

Base

Targets `chore/sdk-admin-apsara-v1` (the migration PR). Auto-retargets to `main` once that merges.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment May 13, 2026 0:30am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ebdc776c-72dc-4eef-8230-b8e28f2c5893

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 25799153603

Coverage remained the same at 42.291%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37542
Covered Lines: 15877
Line Coverage: 42.29%
Coverage Strength: 11.9 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants