fix(sdk): forward existing project name in edit-project update#1607
fix(sdk): forward existing project name in edit-project update#1607rohanchkrabrty wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR threads the project ChangesProject name editing flow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/sdk/react/views-new/projects/components/edit-project-dialog.tsx (1)
102-102: 💤 Low valueConsider including
payload.namein the dependency array for consistency.While the current implementation works correctly (since
namedoesn't affect the form defaults), includingpayload.namealongsidepayload.projectIdandpayload.titlewould make the dependency array more complete and easier to understand.Optional consistency improvement
- }, [payload.projectId, payload.title, reset]); + }, [payload.projectId, payload.name, payload.title, reset]);
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8541b7d0-f202-4c67-ad6b-49608b520b64
📒 Files selected for processing (4)
web/sdk/react/views-new/projects/components/edit-project-dialog.tsxweb/sdk/react/views-new/projects/components/project-columns.tsxweb/sdk/react/views-new/projects/project-details-view.tsxweb/sdk/react/views-new/projects/projects-view.tsx
Coverage Report for CI Build 25799413938Coverage remained the same at 42.249%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
titleinUpdateProjectRequestBody, but the proto requiresname(validated against^[A-Za-z0-9-_]+$) so the server rejected the update.namethroughProjectMenuPayload, the details-view actions menu, andEditProjectPayloadso it's forwarded unchanged in the update body.namestays non-editable in the UI — matches the convention used byproject-general.tsx,rename-project.tsx, and the team-edit dialog.