Skip to content

refactor(frontier): remove org_id from group RPC requests#490

Open
AmanGIT07 wants to merge 1 commit into
mainfrom
refactor/group-rpcs
Open

refactor(frontier): remove org_id from group RPC requests#490
AmanGIT07 wants to merge 1 commit into
mainfrom
refactor/group-rpcs

Conversation

@AmanGIT07

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJul 7, 2026, 7:00 AM

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This change modifies frontier.proto to remove the org_id field from eight Group-related request messages: GetGroupRequest, UpdateGroupRequest, ListGroupUsersRequest, EnableGroupRequest, DisableGroupRequest, DeleteGroupRequest, RemoveGroupUserRequest, and SetGroupMemberRoleRequest. The previously used field numbers for org_id in each message are marked as reserved to prevent reuse. Other fields such as id, group_id, and user_id remain unchanged.

Suggested reviewers: rohilsurana, whoAbhishekSah, rsbh

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No meaningful pull request description was provided, so the change intent cannot be assessed from the description. Add a brief description summarizing the change and why org_id was removed from the group RPC requests.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: removing org_id from group RPC requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
raystack/frontier/v1beta1/frontier.proto (1)

2112-2117: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Reserve the field name in addition to the number.

You reserve the freed field number but not the name. Reserving the name (reserved "org_id";) prevents accidental reuse of org_id in a way that breaks JSON/text-format compatibility. This applies consistently to all eight messages in this change (GetGroupRequest, UpdateGroupRequest, ListGroupUsersRequest, EnableGroupRequest, DisableGroupRequest, DeleteGroupRequest, RemoveGroupUserRequest, SetGroupMemberRoleRequest).

♻️ Example for GetGroupRequest
 message GetGroupRequest {
-  reserved 2;
+  reserved 2;
+  reserved "org_id";

   string id = 1;
   bool with_members = 3;
 }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@raystack/frontier/v1beta1/frontier.proto` around lines 2112 - 2117, The
protobuf messages in this change reserve the old field number but not the
removed field name, so update each affected request type to reserve the original
name as well as the number. In the relevant message definitions for
GetGroupRequest, UpdateGroupRequest, ListGroupUsersRequest, EnableGroupRequest,
DisableGroupRequest, DeleteGroupRequest, RemoveGroupUserRequest, and
SetGroupMemberRoleRequest, add the reserved field name alongside the existing
reserved tag to prevent reuse of org_id and preserve JSON/text-format
compatibility.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@raystack/frontier/v1beta1/frontier.proto`:
- Around line 2112-2117: The protobuf messages in this change reserve the old
field number but not the removed field name, so update each affected request
type to reserve the original name as well as the number. In the relevant message
definitions for GetGroupRequest, UpdateGroupRequest, ListGroupUsersRequest,
EnableGroupRequest, DisableGroupRequest, DeleteGroupRequest,
RemoveGroupUserRequest, and SetGroupMemberRoleRequest, add the reserved field
name alongside the existing reserved tag to prevent reuse of org_id and preserve
JSON/text-format compatibility.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5d4df7ae-d1d1-4534-b3ac-bc1dd004b27c

📥 Commits

Reviewing files that changed from the base of the PR and between ee05c27 and 49c5649.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant