RDKEMW-14906 : VAD detector in Control Manager/Voice SDK#186
Open
RDKEMW-14906 : VAD detector in Control Manager/Voice SDK#186
Conversation
There was a problem hiding this comment.
Pull request overview
Adds voice activity detection (VAD) support and reporting across Control Manager / Voice SDK, including new session-end signaling for silent utterances and extended voice-session telemetry.
Changes:
- Extend voice session telemetry marker schema (version bump) and emit VAD-related stats (voice detected / peak confidence / peak RMS).
- Add a new IPC/session-end result for silent utterances and broadcast it via both legacy IARM and Thunder JSON payloads.
- Introduce a configurable
voice_activity_detection_modepreference and propagate it into XRSR routing (PTT path).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/voice/telemetry/ctrlm_voice_telemetry_events.h | Extends telemetry session struct and stream-end API to carry VAD stats. |
| src/voice/telemetry/ctrlm_voice_telemetry_events.cpp | Emits additional telemetry fields and records VAD stats on stream end. |
| src/voice/ipc/ctrlm_voice_ipc.h | Adds SESSION_END_SILENT_UTTERANCE result type. |
| src/voice/ipc/ctrlm_voice_ipc_iarm_thunder.cpp | Adds Thunder JSON payload support for silent-utterance session end. |
| src/voice/ipc/ctrlm_voice_ipc_iarm_legacy.cpp | Broadcasts a new legacy IARM event for silent sessions. |
| src/voice/ctrlm_voice_obj.h | Adds VAD mode preference and a string-to-XRSR mapping helper. |
| src/voice/ctrlm_voice_obj.cpp | Reads VAD mode from defaults/config/RFC, logs it, and emits silent-utterance IPC; forwards VAD stats to telemetry. |
| src/voice/ctrlm_voice_obj_generic.cpp | Passes configured VAD mode into XRSR route configuration (PTT). |
| src/telemetry/ctrlm_telemetry_markers.h | Updates voice session stats marker documentation and bumps schema version to 3. |
| src/ctrlm_config_default.json | Adds default voice_activity_detection_mode configuration value. |
| include/ctrlm_ipc.h | Adds CTRLM_VOICE_IARM_EVENT_SESSION_SILENT to the main IARM event enum. |
| include/ctrlm_ipc_voice.h | Defines the new silent-session IARM event payload and documents the event. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.