Skip to content

RDKEMW-16763 : rf4ce init failure causes deadlock#198

Open
dwolaver wants to merge 3 commits intodevelopfrom
feature/RDKEMW-16763_rf4ce_init_failure_causes_deadlock
Open

RDKEMW-16763 : rf4ce init failure causes deadlock#198
dwolaver wants to merge 3 commits intodevelopfrom
feature/RDKEMW-16763_rf4ce_init_failure_causes_deadlock

Conversation

@dwolaver
Copy link
Copy Markdown
Contributor

@dwolaver dwolaver commented Apr 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 8, 2026 14:40
jthomp007c
jthomp007c previously approved these changes Apr 8, 2026
View reviewed changes
Copilot AI reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a deadlock during RF4CE HAL initialization by replacing an unbounded wait with a bounded timeout, allowing initialization to fail fast instead of blocking indefinitely.

Changes:

  • Replace sem_wait with sem_timedwait (2s timeout) while waiting for HAL init completion.
  • On timeout, log an error and force init_result_ to CTRLM_HAL_RESULT_ERROR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/rf4ce/ctrlm_rf4ce_network.cpp Outdated
Comment thread src/rf4ce/ctrlm_rf4ce_network.cpp
@dwolaver dwolaver requested a review from a team as a code owner April 8, 2026 15:09
@dwolaver dwolaver requested a review from Copilot April 8, 2026 15:10
egalla204
egalla204 reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@egalla204 egalla204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for test

Copilot AI reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/rf4ce/ctrlm_rf4ce_network.cpp Outdated
Comment thread src/rf4ce/ctrlm_rf4ce_network.cpp
Comment thread src/rf4ce/ctrlm_rf4ce_network.cpp
@dwolaver dwolaver requested a review from Copilot April 8, 2026 15:36
Copilot AI reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/rf4ce/ctrlm_rf4ce_network.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egalla204 egalla204 egalla204 left review comments

Copilot code review Copilot Copilot left review comments

@jthomp007c jthomp007c jthomp007c left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwolaver @jthomp007c @egalla204