Skip to content

Reorganize the code into separate files#24

Open
dabit wants to merge 6 commits into
rdp:masterfrom
dabit:reorganize
Open

Reorganize the code into separate files#24
dabit wants to merge 6 commits into
rdp:masterfrom
dabit:reorganize

Conversation

@dabit

@dabit dabit commented Aug 12, 2013

Copy link
Copy Markdown

While trying to figure out how the gem internals work I noticed that all the code was in a single file.

I reorganized everything into separate files and got rid of Jeweler now using the more up-to-date Bundler for releasing.

No code was changed, except for the definition of Gnuplot::Plot::QUOTED.

Used the current test suite to make sure everything is working as expected.

Later on it might be a good idea to separate the test files too.

@rdp

rdp commented Aug 12, 2013

Copy link
Copy Markdown
Owner

Ok will merge in a week or 2 if there are no objections raised, thanks!

On Mon, Aug 12, 2013 at 4:31 PM, David Padilla notifications@github.comwrote:

While trying to figure out how the gem internals work I noticed that all
the code was in a single file.

I reorganized everything into separate files and got rid of Jeweler now
using the more up-to-date Bundler for releasing.

No code was changed, except for the definition of Gnuplot::Plot::QUOTED.

Used the current test suite to make sure everything is working as expected.

Later on it might be a good idea to separate the test files too.

You can merge this Pull Request by running

git pull https://github.com/dabit/ruby_gnuplot reorganize

Or view, comment on, or merge it at:

#24
Commit Summary

  • Get rid of Jeweler
  • Extract Gnuplot::Plot to its own file
  • Extract Gnuplot::Splot to separate file
  • Extract Dataset, Array and Matrix to their own files
  • Reindent and clean the code
  • Get rid of RbConfig warning while testing

File Changes

Patch Links:

@deric

deric commented Sep 4, 2013

Copy link
Copy Markdown

+1 for code reorganization

@rdp

rdp commented Oct 30, 2019

Copy link
Copy Markdown
Owner

Shoot it has conflicts now, any chance of a rebase for me? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants