Skip to content

chore: bump select to 1.9#671

Merged
zombieJ merged 1 commit into
masterfrom
codex/bump-select-1-9
Jun 30, 2026
Merged

chore: bump select to 1.9#671
zombieJ merged 1 commit into
masterfrom
codex/bump-select-1-9

Conversation

@zombieJ

@zombieJ zombieJ commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary

  • bump @rc-component/tree-select to 1.12.0
  • update @rc-component/select dependency range to ~1.9.0
  • align clear interaction tests and snapshots with @rc-component/select@1.9

Test

  • ut run lint
  • ut run tsc
  • ut test

Summary by CodeRabbit

  • Chores

    • 升级项目版本至 1.12.0
    • 更新了一个核心依赖版本。
  • Tests

    • 调整了清空相关测试的触发方式,与实际交互保持一致。
    • 更新了辅助清空操作的测试实现。

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tree-select Ready Ready Preview, Comment Jun 30, 2026 9:37am

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 140875e7-6f25-4a7e-8ec7-443efeeb2927

📥 Commits

Reviewing files that changed from the base of the PR and between 601bc3c and 4109653.

⛔ Files ignored due to path filters (3)
  • tests/__snapshots__/Select.checkable.spec.tsx.snap is excluded by !**/*.snap
  • tests/__snapshots__/Select.multiple.spec.js.snap is excluded by !**/*.snap
  • tests/__snapshots__/Select.spec.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (3)
  • package.json
  • tests/Select.checkable.spec.tsx
  • tests/util.tsx

概览

将清除按钮(.rc-tree-select-clear)的触发事件从 mouseDown 改为 click,同步更新测试工具函数 clearAll 及相关测试用例,并将包版本升至 1.12.0,依赖 @rc-component/select 升至 ~1.9.0

变更内容

清除按钮事件变更与版本升级

Layer / File(s) 说明
清除按钮触发事件统一改为 click
tests/util.tsx, tests/Select.checkable.spec.tsx
clearAll 工具函数及 checkable 测试用例中,清除按钮触发事件从 fireEvent.mouseDown 改为 fireEvent.click,注释同步更新。
包版本与依赖升级
package.json
包版本从 1.11.0 升至 1.12.0@rc-component/select 依赖从 ~1.8.0 升至 ~1.9.0

估计代码审查难度

🎯 1 (Trivial) | ⏱️ ~3 minutes

可能相关的 PR

  • react-component/tree-select#650:同样修改了 tests/Select.checkable.spec.tsxtests/util.tsx.rc-tree-select-clear 的事件触发方式,与本次变更高度重叠。

小诗

🐇 小兔子轻轻一跳,
鼠标按下变成点击,
清空按钮换新装,
版本升级又一章,
咔哒一声世界亮! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了将 select 依赖升级到 1.9 的主要变更。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/bump-select-1-9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 4109653.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the package version to 1.12.0 and bumps the @rc-component/select dependency to ~1.9.0. It also updates the test suite to use fireEvent.click instead of fireEvent.mouseDown for clearing selections, and updates the corresponding test snapshots. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​rc-component/​select@​1.9.19810010099100

View full report

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.84%. Comparing base (601bc3c) to head (4109653).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          17       17           
  Lines         633      633           
  Branches      196      179   -17     
=======================================
  Hits          632      632           
  Misses          1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

✅ Preview is ready!

PR preview ✅ Ready ✅ Ready
🔗 Preview https://react-component-tree-select-preview-pr-671.surge.sh
📝 Commit4109653
⏱️ Build time22.478s
📦 Size2.1 MB · 75 files
🪵 LogsView logs
📱 MobileScan to open preview on mobile

↩️ Previous: ⚡️ 4109653 · react-component-tree-select-preview-pr-671.surge.sh (open ↗) · 2026-06-30 09:38:27 UTC

🤖 Powered by surge-preview

@zombieJ zombieJ merged commit 224a82b into master Jun 30, 2026
15 of 16 checks passed
@zombieJ zombieJ deleted the codex/bump-select-1-9 branch June 30, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant