keep old snapshot node position updated at applyViewTransitionName#56604
Closed
zeyap wants to merge 1 commit into
Closed
keep old snapshot node position updated at applyViewTransitionName#56604zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
Summary: ## Changelog: [Internal] [Changed] - keep old snapshot node position updated at applyViewTransitionName `createViewTransitionInstance` is only called once in a shadowNode's lifecycle but `applyViewTransitionName` will be called multiple times at each transition for the same shadowNode. Reviewed By: christophpurrer Differential Revision: D102226352
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102226352. |
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Apr 24, 2026
…eact#56604) Summary: ## Changelog: [Internal] [Fixed] - keep old snapshot node position updated at applyViewTransitionName `createViewTransitionInstance` is only called once in a shadowNode's lifecycle but `applyViewTransitionName` will be called multiple times at each transition for the same shadowNode. Reviewed By: christophpurrer Differential Revision: D102226352
|
This pull request has been merged in c9774c1. |
Collaborator
|
This pull request was successfully merged by @zeyap in c9774c1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Fixed] - keep old snapshot node position updated at applyViewTransitionName
createViewTransitionInstanceis only called once in a shadowNode's lifecycle butapplyViewTransitionNamewill be called multiple times at each transition for the same shadowNode.Reviewed By: christophpurrer
Differential Revision: D102226352