Fix Android Fabric text layout after font scale changes#57124
Open
TorinAsakura wants to merge 1 commit into
Open
Fix Android Fabric text layout after font scale changes#57124TorinAsakura wants to merge 1 commit into
TorinAsakura wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #52895.
Close torin-asakura/workspace#123.
When Android receives a live font scale change,
SurfaceHandlerclones the root with the updatedLayoutContextand dirties measurable text nodes. If the surface constraints did not change, the clonedRootShadowNodecan remain layout-clean, solayoutIfNeeded()skips Yoga and text keeps the old layout bounds while drawing with the new font scale.Dirty the cloned root when
fontSizeMultiplierchanges so Fabric recalculates the tree using the updated text measurements.Changelog:
[ANDROID] [FIXED] - Recalculate Fabric root layout after Android font scale changes
Test Plan:
Reproduced with https://github.com/huanguolin/RNAndroidFontIssue on an Android 16 API 36 AVD with New Architecture enabled:
Local native build:
./gradlew ':packages:react-native:ReactAndroid:buildCMakeDebug[arm64-v8a][hermestooling,jsi,etc]' -Preact.internal.useHermesNightly=falseResult: