refactor(winui): share routed host setup - #4419
Merged
Merged
Conversation
- Extract the common routed-host initialization behind a testable contract. - Add real WinUI coverage across every supported Windows target. - Mark executable test projects explicitly as tests and non-packable.
- Use the latest compatible ReactiveUI.Primitives release across the target framework matrix.
glennawatson
marked this pull request as ready for review
July 26, 2026 03:05
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4419 +/- ##
==========================================
+ Coverage 93.15% 93.35% +0.19%
==========================================
Files 345 347 +2
Lines 14965 14921 -44
Branches 1568 1553 -15
==========================================
- Hits 13941 13929 -12
+ Misses 752 731 -21
+ Partials 272 261 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor and dependency maintenance.
What is the new behavior?
The generic and non-generic WinUI routed hosts now use one shared initialization path. Executable test projects explicitly identify themselves as test projects and non-packable projects.
The ReactiveUI.Primitives package family is updated from 7.0.0 to 7.1.0.
What is the current behavior?
The two routed hosts duplicate their initialization logic. Several executable test projects rely on inferred test and packaging metadata. The repository references ReactiveUI.Primitives 7.0.0.
What might this PR break?
None.
Checklist
mainbranchAdditional information
The experimental WinUI test project was removed from this PR and will be revisited separately.