Add patch about replace shlex from pipes on Python 3.13+ to fix build error on new OS. - #28
Open
narukeu wants to merge 2 commits into
Open
Add patch about replace shlex from pipes on Python 3.13+ to fix build error on new OS.#28narukeu wants to merge 2 commits into
narukeu wants to merge 2 commits into
Conversation
Member
|
I think we should apply the upstream patch instead: ninja-build/ninja@9cf13cd (though this may be moot if we manage to release an updated version soon) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried building RosBE on a modern Linux toolchain (Ubuntu 26.04), and found that the current RosBE's Ninja imports the
pipesmodule, which is deprecated in Python 3.13+. This causes build issues on newer GNU/Linux, so I submitted a patch. I made a similar fix in a previous PR where I addedsedto the bash script, but I felt that had the smell of a monkey patch and wasn't appropriate. I think using a patch is more suitable, so I opened a new PR.