Define the CLI interface from one completion schema#9
Merged
Conversation
Complete accepted command aliases and help forms, and enforce unit and executable completion coverage for CLI changes.
Drive parsing, usage, completion, constraints, and generated unit and executable contracts from the same declarative command schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Completion previously maintained a separate command and option inventory from the parser. Recent CLI changes exposed drift: accepted aliases and help forms were missing, while tests sampled only part of the interface. The shared schema makes completion coverage follow interface changes automatically.
Validation
bazel run @rules_go//go -- fmt ./...git diff --exit-codebazel test --test_env=PATH //...(30 tests)bazel run @rules_go//go -- vet ./...bazel run @rules_go//go -- run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.0 run(0 issues)bazel test --test_env=PATH //integration/...(7 tests)