Prepare 1.3.0 for release#88
Open
onelxj wants to merge 4 commits into
Open
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
The frontend type-check tests for the bank-pydantic and kcdc-2025
examples overlaid the locally built @reboot-dev/reboot{,-api,-web,
-react} tarballs but resolved the @reboot-dev/reboot-std{,-api,-react}
packages from the npm registry. That only works when the version the
example pins is already published, so the tests break during release
preparation, when every pin points at the not-yet-published next
version. Overlay the std packages the same way bank-zod already does.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… tests bank-pydantic's frontend/package.json declares mobile as an npm workspace, so an npm install run in frontend/mobile resolves the whole workspace, including the web frontend's registry pins. Those pins are resolved before the locally built tarballs given on the command line are placed in the tree, so npm contacts the registry for them and the install breaks during release preparation, when every pin points at the not-yet-published next version. Run the overlay install at the workspace root instead: command-line specs there replace the root package.json pins outright, and the mobile workspace member's pins then dedupe against the tarball versions already placed in the tree. Also overlay the std packages, which the web frontend (now part of the same install) depends on. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
onelxj
force-pushed
the
onelxj.release_1_3_0
branch
from
81d420b to
a858392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also contains a small fix, check a separate commit.