Presence Library#90
Open
katfang wants to merge 10 commits into
Open
Conversation
added 10 commits
July 14, 2026 14:19
* Only allows passing Presence.Authorizer instead of setting all 3 authorizers. * Test updates to use library format
* Update Presence Library (Python) to take 3 authorizers * Discussion for singleton authorizer vs subclassing: https://github.com/reboot-dev/mono/pull/5140 (comments)
…pp_internal, has_verified_token]) * Update tests to respect new default authorizer for presence
…orizers for all 3 servicers
* Add tests
* methods fail without TokenVerifier
* can override auth with an AuthorizerRule for all 3 servicers
* assert raises if trying to specify specific Authorizers and general AuthorizerRule.
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third time's the charm?
Changes in this PR
presenceinto a library (can passpresence_library()tolibrarieson creating anApplication)presence's default authorizationallow_if(any=[is_app_internal, has_verified_token])AuthorizerRuleinstead of anAuthorizerinto the librariesAuthorizerRuleto set the authorization for all ofpresence_library's servicers instead of having to specify them individually.Docs going in a different PR because honestly, this is probably big enough.