Open
Conversation
Collaborator
|
Great contributions! However please keep these two changes as separate pull requests to make it easier to review and merge accordingly. It also helps with future debugging and reverting. |
Contributor
|
Note to @fire-light42 before merging this I would prefer (though definitely up to you) this wait until after AGP 9, as I have spent months testing and working on AGP 9 changes including Dokka support and other stuff, I really dont want to have to rebegin testing compatibility with the merged projects and removal of docs which does change the functionality a bit. Again up to you though. Overall this is a nice contribution though and this is not to say otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR include
Dokka Documentation Generation
Removing
docsmodule, Now Dokka documentation can be generated directly from the root project.The generated documentation:
There's some package documentation named
packages.mdforappandlibrarymodules generated by AI.