fix of hero CTA links render without navigation targets#1526
fix of hero CTA links render without navigation targets#1526Kuldeep2822k wants to merge 1 commit into
Conversation
|
@Kuldeep2822k is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
✅ Synchronized metadata from Issue #1522:
|
|
@sanjay-kv kindly review it |
Description
The two hero CTA buttons on the
/careerspage — "View Open Positions" and "Learn About Our Culture" — were rendered as<Link>components without any navigation target (toprop missing). This made both buttons completely non-functional; clicking either one did nothing.This fix replaces them with native
<a>tags pointing to the existing#openingsand#culturesection anchors on the same page. Native anchors are used instead of Docusaurus<Link>because Docusaurus's build-time anchor checker cannot detectidattributes set onmotion.sectioncomponents (they only exist at runtime), which would cause false "broken anchor" warnings duringnpm run build.Fixes #1522
Type of Change
Changes Made
src/pages/careers/index.tsx(lines 236–241): Replaced two<Link>components (missingtoprop) with native<a>tags:"View Open Positions"→<a href="#openings">(scrolls to the Job Openings section)"Learn About Our Culture"→<a href="#culture">(scrolls to the Culture & Values section)style={{ textDecoration: "none" }}to preserve the existing button styling.Dependencies
Checklist
npm run buildand it passed successfully with no warnings.