Skip to content

fix of hero CTA links render without navigation targets#1526

Open
Kuldeep2822k wants to merge 1 commit into
recodehive:mainfrom
Kuldeep2822k:Stale-Stats-When-Filter-Returns-Zero
Open

fix of hero CTA links render without navigation targets#1526
Kuldeep2822k wants to merge 1 commit into
recodehive:mainfrom
Kuldeep2822k:Stale-Stats-When-Filter-Returns-Zero

Conversation

@Kuldeep2822k
Copy link
Copy Markdown

Description

The two hero CTA buttons on the /careers page — "View Open Positions" and "Learn About Our Culture" — were rendered as <Link> components without any navigation target (to prop missing). This made both buttons completely non-functional; clicking either one did nothing.

This fix replaces them with native <a> tags pointing to the existing #openings and #culture section anchors on the same page. Native anchors are used instead of Docusaurus <Link> because Docusaurus's build-time anchor checker cannot detect id attributes set on motion.section components (they only exist at runtime), which would cause false "broken anchor" warnings during npm run build.

Fixes #1522

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

  • src/pages/careers/index.tsx (lines 236–241): Replaced two <Link> components (missing to prop) with native <a> tags:
    • "View Open Positions"<a href="#openings"> (scrolls to the Job Openings section)
    • "Learn About Our Culture"<a href="#culture"> (scrolls to the Culture & Values section)
  • Added style={{ textDecoration: "none" }} to preserve the existing button styling.

Dependencies

  • No new dependencies.
  • No version updates or configuration changes required.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors.
  • I ran npm run build and it passed successfully with no warnings.
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 16, 2026

@Kuldeep2822k is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions Bot added in-review The current changes are in review and would need approval and testing before merging level 1 10 points recode this is label for leaderboard labels May 16, 2026
@github-actions github-actions Bot added this to the recode:launch 3.0 milestone May 16, 2026
@github-actions github-actions Bot added gssoc:approved gssoc label level:beginner gssoc labels. 20pts type:design gssoc labels 10pts type:refractor gssoc label 10pts labels May 16, 2026
@github-actions
Copy link
Copy Markdown

✅ Synchronized metadata from Issue #1522:

  • Labels: level 1, recode, level:beginner, gssoc:approved, type:design, type:refractor
  • Milestone: recode:launch 3.0

@Kuldeep2822k
Copy link
Copy Markdown
Author

@sanjay-kv kindly review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved gssoc label in-review The current changes are in review and would need approval and testing before merging level:beginner gssoc labels. 20pts level 1 10 points recode this is label for leaderboard type:design gssoc labels 10pts type:refractor gssoc label 10pts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: hero CTA links render without navigation targets

1 participant