Skip to content

fix: resolve showcase page crash caused by undefined isDark prop#1531

Open
pericharlabindhumadhavi-data wants to merge 1 commit into
recodehive:mainfrom
pericharlabindhumadhavi-data:fix-showcase-crash
Open

fix: resolve showcase page crash caused by undefined isDark prop#1531
pericharlabindhumadhavi-data wants to merge 1 commit into
recodehive:mainfrom
pericharlabindhumadhavi-data:fix-showcase-crash

Conversation

@pericharlabindhumadhavi-data
Copy link
Copy Markdown

Description

Fixed the dark/light theme rendering issue on the Showcase page.

The problem occurred because theme-related styling and the isDark prop handling were inconsistent inside the Showcase components, causing incorrect rendering behavior and runtime issues in some cases.

Fixes #1501


Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)

Changes Made

  • Fixed theme rendering issues on the Showcase page
  • Corrected isDark prop handling in Showcase components
  • Improved dark/light mode background and text rendering
  • Cleaned up Showcase page styling for consistent appearance

Dependencies

  • No new dependencies added
  • No version updates required

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors.
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

##Screenshots / Demo
Before
Showcase page crashed due to undefined isDark prop.
https://github.com/user-attachments/assets/712da467-7587-4cf0-95e9-ad276d0399e2
image
image

After
Showcase page renders correctly without runtime errors.
Theme/layout works properly after removing the undefined reference.
https://github.com/user-attachments/assets/d280cedc-696c-414e-8b70-6b5c1eb58fbb
image
image

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 16, 2026

@pericharlabindhumadhavi-data is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions Bot added in-review The current changes are in review and would need approval and testing before merging level 1 10 points recode this is label for leaderboard labels May 16, 2026
@github-actions github-actions Bot added this to the recode:launch 3.0 milestone May 16, 2026
@github-actions
Copy link
Copy Markdown

✅ Synchronized metadata from Issue #1501:

  • Labels: level 1, recode
  • Milestone: recode:launch 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review The current changes are in review and would need approval and testing before merging level 1 10 points recode this is label for leaderboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Dark/Light Theme Not Rendering Properly on Showcase Page

1 participant