fix: resolve showcase page crash caused by undefined isDark prop#1531
fix: resolve showcase page crash caused by undefined isDark prop#1531pericharlabindhumadhavi-data wants to merge 1 commit into
Conversation
|
@pericharlabindhumadhavi-data is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
✅ Synchronized metadata from Issue #1501:
|
Description
Fixed the dark/light theme rendering issue on the Showcase page.
The problem occurred because theme-related styling and the
isDarkprop handling were inconsistent inside the Showcase components, causing incorrect rendering behavior and runtime issues in some cases.Fixes #1501
Type of Change
Changes Made
isDarkprop handling in Showcase componentsDependencies
Checklist
npm run buildand attached screenshot(s) in this PR.##Screenshots / Demo


Before
Showcase page crashed due to undefined isDark prop.
https://github.com/user-attachments/assets/712da467-7587-4cf0-95e9-ad276d0399e2
After


Showcase page renders correctly without runtime errors.
Theme/layout works properly after removing the undefined reference.
https://github.com/user-attachments/assets/d280cedc-696c-414e-8b70-6b5c1eb58fbb