Skip to content

[Console] Allow short command "p" on ProcessCommand#7931

Merged
TomasVotruba merged 6 commits intomainfrom
allow-short-command-p
Mar 27, 2026
Merged

[Console] Allow short command "p" on ProcessCommand#7931
TomasVotruba merged 6 commits intomainfrom
allow-short-command-p

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Mar 16, 2026

with add e2e test for it.

Fixes rectorphp/rector#9693

@samsonasik samsonasik requested a review from TomasVotruba March 16, 2026 21:23
@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@samsonasik
Copy link
Copy Markdown
Member Author

synced latest main branch 👍 , @TomasVotruba ready to merge 👍

@samsonasik
Copy link
Copy Markdown
Member Author

It seems the real solution is by using setAliases(['p']) on ProcessCommand 👍 41447c0

Ready to merge 👍

@samsonasik samsonasik changed the title [Console] Allow short command "p" on ConsoleApplication [Console] Allow short command "p" on ProcessCommand Mar 17, 2026
@TomasVotruba
Copy link
Copy Markdown
Member

Thanks 👍

@TomasVotruba TomasVotruba merged commit d913384 into main Mar 27, 2026
64 of 65 checks passed
@TomasVotruba TomasVotruba deleted the allow-short-command-p branch March 27, 2026 11:04
samsonasik added a commit that referenced this pull request Mar 28, 2026
* [Console] Allow short command "p" on ConsoleApplication

* Fix

* Fix latest phpstan assert

* [ci-review] Rector Rectify

* with setAliases()

---------

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Since 2.3.9, short command name is broken

3 participants