Don't fail when rpm is not installed#99
Merged
Merged
Conversation
Member
Author
|
This fixes the root cause of the issue seen at redhat-developer/dotnet-regular-tests#412 |
omajid
force-pushed
the
alpine-no-rpm-crash
branch
2 times, most recently
from
66d5b61 to
150663a
Compare
omajid
force-pushed
the
alpine-no-rpm-crash
branch
7 times, most recently
from
2eb5fc0 to
f9c3baa
Compare
Member
Author
|
In environments where rpm is not available, the
TestRunner.LogEnvironment method throws an exception:
Unhandled exception: System.ComponentModel.Win32Exception (2): An
error occurred trying to start process 'rpm' with working directory
'Samples'. No such file or directory
The code tries to handle these environments (like alpine), but doesn't
catch the actual Win32Exception thrown when the rpm command is not
found. It only catches InvalidOperationException (which happens when rpm
command exits with an error).
Also update CI to catch issues like this by adding an alpine leg.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
omajid
force-pushed
the
alpine-no-rpm-crash
branch
from
f9c3baa to
8a500d7
Compare
Member
Author
|
cc @ayakael |
tmds
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In environments where rpm is not available, the
TestRunner.LogEnvironment method throws an exception:
The code tries to handle these environments (like alpine), but doesn't catch the actual Win32Exception thrown when the rpm command is not found. It only catches InvalidOperationException (which happens when rpm command exits with an error).