fix(RHDHBUGS-3464): lowercase metadata in the chart to resolve k8's RFC 1123 format.#469
Draft
shashankkestwal wants to merge 1 commit into
Draft
fix(RHDHBUGS-3464): lowercase metadata in the chart to resolve k8's RFC 1123 format.#469shashankkestwal wants to merge 1 commit into
shashankkestwal wants to merge 1 commit into
Conversation
Signed-off-by: skestwal <skestwal@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
shashankkestwal
changed the title
shashankkestwal
changed the title
shashankkestwal
changed the title
rm3l
reviewed
Jul 13, 2026
rm3l
left a comment
rm3l
left a comment
Member
There was a problem hiding this comment.
@shashankkestwal Thanks for this PR, but I think there is already another open PR fixing the same issue: #466 (on main).
And #465 against release-1.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: skestwal skestwal@redhat.com
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Description of the change
In case of the .Chart.Version not a lower case value the job failed. The uppercase values violates Kubernetes DNS subdomain naming rules (RFC 1123). The API server rejects the Job, so it is never created.
Which issue(s) does this PR fix or relate to
How to test changes / Special notes to the reviewer
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Runpre-commit run --all-filesto run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.pre-commithook.ct lintcommand.