fix(scorecard): remove redundant /alpha re-export of translations - #4095
Conversation
Changed Packages
|
PR Summary by QodoFix scorecard plugin: remove redundant /alpha translation entrypoint
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
🤖 Review · |
Code Review by Qodo
Context used✅ Compliance rules (platform):
11 rules✅ Cross-repo context Explored:
repo: redhat-developer/rhdh (sha: ddfe8d07) Explored:
repo: redhat-developer/rhdh-local (sha: 2ae9e8c8) Not relevant to this PR:
redhat-developer/rhdh-chart Not relevant to this PR:
redhat-developer/rhdh-operator 1. README still advertises /alpha
|
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3522 Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
6338cdd to
c66ac1d
Compare
|
|
🤖 Finished Review · ✅ Success · Started 4:49 AM UTC · Completed 5:06 AM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4095 +/- ##
=======================================
Coverage 57.93% 57.93%
=======================================
Files 2396 2396
Lines 96104 96104
Branches 26845 26852 +7
=======================================
Hits 55675 55675
Misses 40223 40223
Partials 206 206
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ReviewFindingsHigh
Medium
Low
Labels: PR modifies translation export paths in the scorecard plugin |
| "exports": { | ||
| ".": "./src/index.ts", | ||
| "./alpha": "./src/alpha.ts", | ||
| "./legacy": "./src/legacyExports.ts", |
There was a problem hiding this comment.
[medium] breaking-change
Removing the ./alpha export entry point removes a documented import path. The 3.0.0 CHANGELOG stated 'translations remain at ./alpha', creating a contract consumers could rely on. Any consumer using the /alpha import path will get a module-not-found error after upgrading. The symbols are still available from the main entry point, so this is a path removal rather than a functional API break.
Suggested fix: Change the changeset from patch to minor at minimum. If external consumers may be using the /alpha path, use major instead.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@red-hat-developer-hub/backstage-plugin-scorecard': patch | |||
There was a problem hiding this comment.
[medium] semver-classification
The changeset classifies this as a patch change, but removing a public export path is not a bug fix. It should be at least minor since it removes a documented (though transitional) import path.
Suggested fix: Change the changeset from patch to minor, or major if the team believes external consumers actively use the /alpha path.
|
I have not verified the PR, please feel free to verify and merge. I will be deleting this comment once verified. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |



Description
Removes the redundant
/alphare-export of translations (scorecardTranslationRef,scorecardTranslations) from the scorecard plugin. After PR #3953 (RHIDP-14416) promoted the scorecard NFS plugin from/alphato stable, translations were already exported from the main entry point (src/index.ts). The/alphare-export insrc/alpha.tswas misleading, making it appear translations were still an alpha feature.This change deletes
src/alpha.tsentirely (it had no other exports), removes the./alphaentry point frompackage.jsonexports/typesVersions, and deletes the now-unnecessaryreport-alpha.api.mdAPI report.Root cause
src/alpha.tscontainedexport * from './translations'which duplicated the stable exports insrc/index.ts. No code in the repository imports from the/alphapath — the only reference was inREADME.mdas a migration example showing the old import path.Fixed
Test Plan
src/index.tsstill exportsscorecardTranslationRefandscorecardTranslations/alphaentry pointreport-alpha.api.mdneeded)Checklist
Note
Made with Cursor