fix(intelligent-assistant): MCP settings panel fills space in docked/overlay mode (RHDHBUGS-3576) - #4213
Conversation
…overlay mode The PatternFly chatbot Settings component's default CSS includes justify-content: center, overflow: scroll, and border-bottom on form rows. In docked/overlay mode these defaults caused the MCP settings panel to appear visually smaller than its container, with gray gaps visible around it. Fix by overriding the Settings wrapper with proper flex-fill behavior (flex: 1, minHeight: 0) throughout the form container chain, removing borders/overflow, and aligning content to flex-start instead of center. Fixes: RHDHBUGS-3576 Assisted-by: Composer Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3576 Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Changed Packages
|
PR Summary by QodoFix MCP settings panel to flex-fill in docked/overlay chatbot modes
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4213 +/- ##
==========================================
+ Coverage 58.33% 58.37% +0.03%
==========================================
Files 2432 2433 +1
Lines 96774 96916 +142
Branches 26918 26946 +28
==========================================
+ Hits 56452 56570 +118
- Misses 38859 38883 +24
Partials 1463 1463
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ciiay
left a comment
There was a problem hiding this comment.
Hi @rohitratannagar , thanks for the pr 👏
Have you verified it on RHDH? Can you upload the screenshot or screen recording after the fix?
…tings panel The Settings wrapper elements were using --pf-t--global--background--color--primary--default which diverges from the chatbot's --floating--default token in dark mode, causing a visible dark strip below the MCP servers table content. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Updated in the UI (tested in rhdh-local) !! |





Summary
Fixed
before fix
After fix (in rhdh-local)
Root Cause
The PatternFly chatbot
Settingscomponent's default CSS (justify-content: center,overflow: scroll,border-bottomon form rows) caused the MCP settings panel to appear visually smaller than its container in docked/overlay modes, with gray gaps visible around it.Changes
Fixed by overriding the Settings wrapper chain with proper flex-fill behavior:
flex: 1andminHeight: 0throughout the form container chain (container → form → row → McpServersSettings root)justify-contenttoflex-start(wascenter, which vertically centered content in column mode)overflowtohidden(wasscroll, which could show scrollbar artifacts)border: 'none'at all levels to eliminate the gray border fromborder-bottom: 1px solidChecklist
yarn tsc:full)yarn test --watchAll=false)yarn build:all)Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3576
Made with Cursor