docs(#4223): RHIDP-15302 migration design document - #4225
docs(#4223): RHIDP-15302 migration design document#4225fullsend-ai-coder[bot] wants to merge 4 commits into
Conversation
Create the RHIDP-15302 migration design document at workspaces/boost/specifications/ai-asset-upstream-migration-design.md covering all seven AI-asset categories per Decision 1. The document maps current RHDH entity kinds and spec.type values to their upstream Backstage targets with confidence levels, provides field-level transformation rules per category, identifies consumer-facing changes (catalog UI filters, entity refs, API queries), and defines a backward compatibility strategy (keep rhdh.io/ai-asset-category annotation for one major version). Key decisions reflected: - MCP server: kind already aligned (API), no rename to McpServer - Model server: conditional on backstage#34476 (Resource to API) - Skills/rules: AiResource shipped upstream, casing alignment - Agent/AI model/skill-bundle: low confidence, track upstream - vector-store/ai-tool: explicitly out of scope - Sign-off section present but unsigned (human follow-up) Cross-links added from migration-readiness/spec.md and tasks.md group 8 (8.1-8.4 marked complete). Cites #4211 (model-server downstream) and #4164 (AiResource agent schema). Closes #4223
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4225 +/- ##
=======================================
Coverage 58.34% 58.34%
=======================================
Files 2433 2433
Lines 96793 96793
Branches 26925 26925
=======================================
Hits 56470 56470
Misses 38853 38853
Partials 1470 1470
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
/fs-fix CI issues (prettier) |
|
🤖 Finished Fix · ✅ Success · Started 9:59 AM UTC · Completed 10:11 AM UTC Commit: |
Reformat markdown tables in ai-asset-upstream-migration-design.md to satisfy prettier CI checks. Addresses review feedback on #4225
🔧 Fix agent — iteration 1 (human-triggered)Fixed prettier CI failure by reformatting markdown tables in ai-asset-upstream-migration-design.md. Changes are purely cosmetic (table column alignment and trailing whitespace removal). Fixed (1):
Tests: passed Updated by fullsend fix agent |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 10:19 AM UTC · Completed 10:32 AM UTC Commit: |
ReviewFindingsLow
Previous runReviewFindingsHigh
Low
Labels: PR modifies documentation files exclusively under workspaces/boost/ Next steps:
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
workspace/boost
Correct broken cross-links to the design doc, complete model-server field mapping for backstage#34476, and clarify MCP remotes, AiResource citations, and heading style. Signed-off-by: Marek Libra <marek.libra@gmail.com>
|
Added manually crafted commit. |
|
/fs-review |
|
🤖 Review · ❌ Terminated · Started 11:36 AM UTC · Ended 11:54 AM UTC Commit: |
Use catalog annotation filter paths, spell out Skill/Rule and spec.models transformations, and dedupe Out of scope.
Superseded by updated review
| - [ ] 8.2 Document transformation rules for each AI asset category (RHIDP-15302) | ||
| - [ ] 8.3 Identify consumer-facing changes: catalog UI filters, entity refs, API queries (RHIDP-15302) | ||
| - [ ] 8.4 Document backward compatibility strategy (e.g., keep annotation for one major version) (RHIDP-15302) | ||
| > Tasks 8.1-8.4 implemented in [ai-asset-upstream-migration-design.md](../../../specifications/ai-asset-upstream-migration-design.md) via [#4223](https://github.com/redhat-developer/rhdh-plugins/issues/4223). |
There was a problem hiding this comment.
[low] blockquote-formatting-convention
The new blockquote does not follow the established bold-label-with-colon pattern used elsewhere in tasks.md (e.g., '> Label: description').
| | --------------------- | ----------------- | -------------------------------- | ------------------------------------------------------------- | | ||
| | `kind` | `Resource` | `API` | Kind change from Resource to API. | | ||
| | `spec.type` | `ai-model-server` | `ai-model-server` | No change to type value. | | ||
| | `spec.owner` | Standard | Standard | No change (both kinds use `spec.owner`). | |
There was a problem hiding this comment.
[low] cross-reference-consistency
The confidence level label 'Medium-High' uses a regular ASCII hyphen while authoritative definitions in other specification files use an en-dash ('Medium-High' vs 'Medium–High').
fullsend-ai-review
Bot
added
the
ready-for-merge
|
🤖 Finished Review · ✅ Success · Started 11:36 AM UTC · Completed 11:54 AM UTC Commit: |
|
|
Converting to draft, still thinking about the approach |
1 participant
Create the RHIDP-15302 migration design document at workspaces/boost/specifications/ai-asset-upstream-migration-design.md covering all seven AI-asset categories per Decision 1.
The document maps current RHDH entity kinds and spec.type values to their upstream Backstage targets with confidence levels, provides field-level transformation rules per category, identifies consumer-facing changes (catalog UI filters, entity refs, API queries), and defines a backward compatibility strategy (keep rhdh.io/ai-asset-category annotation for one major version).
Key decisions reflected:
Cross-links added from migration-readiness/spec.md and tasks.md group 8 (8.1-8.4 marked complete). Cites #4211 (model-server downstream) and #4164 (AiResource agent schema).
Closes #4223
Post-script verification
agent/4223-migration-design-doc)50e15634144ae07c82570c13c6fd960e03e20765..HEAD)