docs(#4232): add AiResource typed variant package convention - #4233
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
docs(#4232): add AiResource typed variant package convention#4233fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add an "AiResource typed variant packages" section to the ai-integrations workspace AGENTS.md documenting the discriminated-union package pattern: each spec.type variant (skill, rule, agent, mcp-server) gets its own dedicated catalog-model and catalog-backend-module package pair. This prevents future code agents from placing typed-variant types in ai-experience-common (as happened in PR #4164) and provides a 5-step checklist for creating new typed variants. Closes #4232
fullsend-ai-coder
Bot
requested review from
a team,
Lucifergene,
gabemontero,
johnmcollier,
karthikjeeyar and
rohitkrai03
as code owners
August 10, 2026 15:15
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4233 +/- ##
=======================================
Coverage 58.40% 58.40%
=======================================
Files 2438 2438
Lines 96960 96960
Branches 26937 26939 +2
=======================================
Hits 56628 56628
Misses 40135 40135
Partials 197 197
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
gabemontero
reviewed
Aug 10, 2026
gabemontero
left a comment
gabemontero
left a comment
Contributor
There was a problem hiding this comment.
@johnmcollier I'll defer to you on this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an "AiResource typed variant packages" section to the ai-integrations workspace AGENTS.md documenting the discriminated-union package pattern: each spec.type variant (skill, rule, agent, mcp-server) gets its own dedicated catalog-model and catalog-backend-module package pair. This prevents future code agents from placing typed-variant types in ai-experience-common (as happened in PR #4164) and provides a 5-step checklist for creating new typed variants.
Closes #4232
Post-script verification
agent/4232-airesource-variant-convention)51a6bc26febbc5a99dce25244441b8d1a5603a92..HEAD)