fix(ci): derive catalog index image dynamically from branch - #5122
fix(ci): derive catalog index image dynamically from branch#5122jonkoops wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5122 +/- ##
==========================================
- Coverage 63.69% 59.96% -3.74%
==========================================
Files 123 111 -12
Lines 2424 2198 -226
Branches 571 550 -21
==========================================
- Hits 1544 1318 -226
Misses 878 878
Partials 2 2
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
nickboldt
left a comment
nickboldt
left a comment
There was a problem hiding this comment.
works for me, as we'll always have a :x.y tag even if :next and :latest float around
|
/retest |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
|
@nickboldt please don't sync the branch with |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
398c903 to
8a04d7d
Compare
|
@jonkoops: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Moving to draft while the prerequisite wrapper removal PR is prepared. This PR will be rebased on top of it once the wrappers have been replaced with |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
8a04d7d to
874cec5
Compare
Populate CATALOG_INDEX_IMAGE with a default based on RELEASE_VERSION so CI always uses the correct catalog index without hardcoding. Remove the temporary CATALOG_INDEX_IMAGE_OVERRIDE pin to :1.10 that was added as an interim measure in redhat-developer#5263. Ref: RHIDP-14348 Signed-off-by: Jon Koops <jonkoops@gmail.com>
874cec5 to
d0e3004
Compare
|
The container image build workflow finished with status: |
|
4 participants
PR #4860 (RHIDP-14348) added
RELEASE_VERSIONandCATALOG_INDEX_IMAGEinfrastructure toenv_variables.shwith the stated goal of replacing the hardcoded catalog index tag, but left the default empty. #5263 added a temporaryCATALOG_INDEX_IMAGE_OVERRIDEpin to:1.10as an interim measure while the catalog index on:nextwas broken.This PR removes the override and populates the default from
RELEASE_VERSION, giving usmain→:next,release-1.10→:1.10automatically. The:next/:2.0catalog index already has wrappers removed, but CI cannot consume it until the existing wrappers in the RHDH repo are migrated toref://references (RHIDP-13226). Gangway overrides for RC/GA verification continue to work; an explicitCATALOG_INDEX_IMAGEprovided externally takes precedence over the default.RHIDP-14348