Skip to content

Add image build support for component deployment#5957

Draft
vrubezhny wants to merge 1 commit into
redhat-developer:mainfrom
vrubezhny:feature/image-build-support
Draft

Add image build support for component deployment#5957
vrubezhny wants to merge 1 commit into
redhat-developer:mainfrom
vrubezhny:feature/image-build-support

Conversation

@vrubezhny

@vrubezhny vrubezhny commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Enables the deploy command to build container images as part of
the deployment flow. Uses podman, docker, or buildah in the
OpenShift terminal so users can interact with registry auth prompts.

Key changes:

  • ContainerRuntimeDetector: Detects available runtime (podman > docker > buildah)
  • ApplyCommandExecutor: Builds image components in terminal instead of skipping
  • Unit tests: ContainerRuntimeDetector, image build logic, manifest URI handling,
    deploy state loading
  • Integration tests: Runtime detection, deploy/undeploy with inlined resources,
    local image build without registry

Assisted-By: Claude Opus 4.6 noreply@anthropic.com

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.95775% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.03%. Comparing base (da60441) to head (c11a77f).
⚠️ Report is 1879 commits behind head on main.

Files with missing lines Patch % Lines
src/devfile/applyCommand.ts 86.95% 1 Missing and 2 partials ⚠️
src/util/containerRuntime.ts 95.83% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5957       +/-   ##
===========================================
+ Coverage   32.37%   51.03%   +18.66%     
===========================================
  Files          85      115       +30     
  Lines        6505    10435     +3930     
  Branches     1349     2330      +981     
===========================================
+ Hits         2106     5326     +3220     
- Misses       4399     5104      +705     
- Partials        0        5        +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vrubezhny vrubezhny force-pushed the feature/image-build-support branch 2 times, most recently from ac9f931 to a491e02 Compare July 13, 2026 01:31
@vrubezhny vrubezhny marked this pull request as draft July 13, 2026 02:16
Enables the deploy command to build container images as part of
the deployment flow. Uses podman, docker, or buildah in the
OpenShift terminal so users can interact with registry auth prompts.

Key changes:
- ContainerRuntimeDetector: Detects available runtime (podman > docker > buildah)
- ApplyCommandExecutor: Builds image components in terminal instead of skipping
- Unit tests: ContainerRuntimeDetector, image build logic, manifest URI handling,
  deploy state loading
- Integration tests: Runtime detection, deploy/undeploy with inlined resources,
  local image build without registry

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
@vrubezhny vrubezhny force-pushed the feature/image-build-support branch from a491e02 to c11a77f Compare July 13, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant