fix RESP3 mismatches#471
Merged
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
* ft.config get * fix brittle TS.INFO tests (server version logic) * more runtime server version checks; profiled RESP3 layout
* ft.config get * fix brittle TS.INFO tests (server version logic) * more runtime server version checks; profiled RESP3 layout * dotnet format * the bot is right
- normalize time series test namespaces
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e65015. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A few commands give different result shapes between RESP2 and RESP3, and require custom processing; this PR fixes those, making them work with either shape, interchangeably; usually this means arrays becoming maps, which by itself would be fine, but: the actual nesting/indenting/etc is changed at the same time - for example, a single flat array with a "stride" might become a jagged nesting of map[key, array]. This can vary between server versions - for example, search on v7 using RESP3 uses a different layout to v8 using RESP3; the implementation here attempts to handle things based on inspection of what arrives, rather than hard coding versions to layouts.
Affected areas:
To ensure future compliance, we change
[RunPerProtocol]to be implicit (RESP2+RESP3) on all integration tests (tests can still use explicit[RunPerProtocol]to change the combination, but this would be rare; the default of "test everything on RESP2 and RESP3" is a good one).Note
Medium Risk
Updates core response-parsing logic to accept multiple RESP3 map/array layouts across Redis module commands; mistakes could cause subtle data-shape regressions at runtime. Changes are mostly additive/branching, but touch widely-used parsing paths for search, timeseries, streams, and JSON.
Overview
Fixes multiple RESP3 vs RESP2 response-shape mismatches by expanding
ResponseParserto detect RESP3Map/wrapped-array layouts and normalize them into the existing object model (notably TimeSeriesMGET/MRANGE, rules/labels, streams, FT spellcheck/config dictionaries, and profile search/aggregate parsing across v7/v8 layouts).Updates JSON commands to use shared parsers for
JSON.TYPEandJSON.NUMINCRBYso RESP3 arrays and RESP2 JSON-string payloads both work.Test infrastructure now defaults integration tests to run under both RESP2 and RESP3, infers Redis server version from the first shared connection, and re-validates skip logic at runtime via
AssertVersion; several tests were adjusted accordingly (including unique JSON keys and TimeSeries test namespaces/constructors).Reviewed by Cursor Bugbot for commit b426103. Bugbot is set up for automated code reviews on this repo. Configure here.