Support the KNN shard-ratio feature#494
Open
mgravell wants to merge 3 commits into
Open
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2bab72c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

from 8.6.1,
FT.HYBRID KNNhas a newSHARD_K_RATIOfeature: RediSearch/RediSearch#8227Note
Medium Risk
Adds a new KNN query parameter that affects search execution and modifies the public API surface for
VectorSearchMethod.NearestNeighbour, which could impact consumers and query behavior. Test skipping logic was also adjusted to defer version checks, which could hide/alter CI coverage if misused.Overview
Adds support for Redis 8.6.1+
FT.HYBRID KNNSHARD_K_RATIOby extendingVectorSearchMethod.NearestNeighbourwith an optionalshardRatioand emittingSHARD_K_RATIOin the generated argument list.Updates the shipped/unshipped public API to reflect the new overload while retaining a binary-compat
NearestNeighbour(int, int?)signature, and expands unit/integration tests to cover shard-ratio scenarios plus addsdeferVersionCheck/overrideVersionpaths to make version-based skips rely on detected server version.Reviewed by Cursor Bugbot for commit 285a6a9. Bugbot is set up for automated code reviews on this repo. Configure here.