Opt-in property references through the prop macro (v/26.1) - #1897
Draft
JakeSCahill wants to merge 1 commit into
Draft
Opt-in property references through the prop macro (v/26.1)#1897JakeSCahill wants to merge 1 commit into
JakeSCahill wants to merge 1 commit into
Conversation
Backport of the property-reference migration to the 26.1 branch,
validated against this branch's own published JSON
(redpanda-properties-v26.1.14.json): plain-backtick property mentions
in prose become prop macro calls (738 across 77 files, the five
ambiguous separator-free names deliberately left plain), all config_ref
calls become prop calls with helm-path=auto, and the overrides file,
generated partials, and published JSON attachment are converted to
match what the fixed property extractor emits.
Includes the same two manual fixes as main: the single-use {config-ref}
attribute indirection is inlined, and the table row for the removed
cloud_storage_reconciliation_interval_ms property is deleted.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In plain English
Same change as the main-branch migration (#1896), for the 26.1 docs: property mentions are explicitly marked and build-verified instead of guessed by the UI, and the deprecated
config_refmacro is gone from this branch's content. Every converted name was validated against this branch's own published property data (v26.1.14) — the macro is version-aware, so 26.1 pages validate against 26.1 data and link only within 26.1 pages.prop:macro): merge order Clarify that we do not support autoscalers #249 → #253 → UBB - Private Offers for Dedicated #251 → Update minimum subnet ip range #254.prop:...text until registration lands.Contents
admin,brokers,rack,retries,superusersleft plain — those are the false-positive words that motivated opt-in).config_refcalls →propwithhelm-path=auto(fixes thestorage.tiered.config.mislabeling of non-tiered properties on Kubernetes pages).{config-ref}indirection, removed the deadcloud_storage_reconciliation_interval_msrow.Full explainer:
macros/PROPERTY_AND_ENTERPRISE_REFERENCES.adocin docs-extensions-and-macros#254.