[CORE-15767] rptest: retry on exception for all_partitions_scrubbed#29837
Merged
dotnwat merged 1 commit intoredpanda-data:devfrom Mar 19, 2026
Merged
[CORE-15767] rptest: retry on exception for all_partitions_scrubbed#29837dotnwat merged 1 commit intoredpanda-data:devfrom
rptest: retry on exception for all_partitions_scrubbed#29837dotnwat merged 1 commit intoredpanda-data:devfrom
Conversation
The `all_partitions_scrubbed()` check in `_post_test_anomaly_check` calls `get_cloud_storage_anomalies()`, which can raise a 404 error when racing with a partition move. This is a transient failure. Pass `retry_on_exc=True` so the scrub check retries on transient errors instead of immediately failing the test.
Contributor
There was a problem hiding this comment.
Pull request overview
Improves rptest post-test internal scrub validation robustness by retrying the all_partitions_scrubbed() polling loop when transient exceptions occur during cloud-storage anomaly queries (e.g., HTTP 404 races during partition movement).
Changes:
- Pass
retry_on_exc=Trueto thewait_until()call that waits for all partitions to be scrubbed. - Reformat the
wait_until()invocation for readability while adding the new parameter.
dotnwat
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
all_partitions_scrubbed()check in_post_test_anomaly_checkcallsget_cloud_storage_anomalies(), which can raise a 404 error when racing with a partition move. This is a transient failure.Pass
retry_on_exc=Trueso the scrub check retries on transient errors instead of immediately failing the test.Backports Required
Release Notes