fix(data-deploy): bundle jekyll + flavor pubid in one deploy bundle - #56
Merged
Conversation
The Pages build ran ruby/setup-ruby with bundler-cache and no BUNDLE_GEMFILE, so it bundled each data repo's own Gemfile (relaton + pubid, no jekyll) and never used Gemfile.deploy (jekyll, no pubid). jekyll build thus lacked jekyll, and even via Gemfile.deploy the jekyll-index plugin could not resolve Pubid::<Flavor>::Identifier to reconstruct structured DocIDs. Make Gemfile.deploy eval_gemfile the repo's own Gemfile and layer the Jekyll toolchain on top, so one shared file carries BOTH jekyll AND the flavor's relaton + pubid pins. Point the build job's BUNDLE_GEMFILE at Gemfile.deploy so the bundler-cache install and jekyll build both resolve against it. Add rspec structural guards for the deploy Gemfile and the workflow env, and refresh the data-index README now that the theme from_hash fix has landed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Completes hand-off
relaton__support__data-deploy-gemfile-pubid.md.The Pages
data-deploybuild ranruby/setup-rubywithbundler-cache: trueand noBUNDLE_GEMFILE, so it bundled each data repo's ownGemfile(relaton + pubid, no jekyll) and never actually usedGemfile.deploy(jekyll, no pubid). Sobundle exec jekyll buildhad no jekyll — and even viaGemfile.deploythe theme'sjekyll-indexplugin could not resolvePubid::<Flavor>::Identifierto reconstruct structured DocIDs, degrading to fallback strings like2010 IEC IEC.Changes
cimas-config/gh-actions/data/Gemfile.deploy—eval_gemfiles the repo's ownGemfileand layers the Jekyll toolchain (jekyll, csv, jekyll-paginate, kramdown-parser-gfm, webrick) on top. One shared file now carries both jekyll and the flavor's relaton + pubid pins; dropped the unusedminimaand its ownsourceline (inherited from the eval'd Gemfile, avoiding bundler's multi-source warning)..github/workflows/data-deploy.yml—build_index_pagejob setsenv: BUNDLE_GEMFILE: ${{ github.workspace }}/Gemfile.deploy, so both the bundler-cache install andbundle exec jekyll buildresolve against it.data-index/README.adoc— refreshed the staleWARNING(themefrom_hashfix has landed; the deploy bundle now carries pubid).Tests
bundle exec rake→ 16 examples, 0 failures. Also verified via bundler's DSL that the merged dependency set carries relaton + pubid + the jekyll toolchain with no multi-source warning.This workflow now hard-requires the new
Gemfile.deploy(and a rootGemfile) present in every repo callingdata-deploy.yml@main. Re-syncGemfile.deployto the data repos via Cimas before/with merging this, or their builds will failbundle install. Additionally, confirm one flavor end-to-end (bundle exec jekyll buildfor iso → grep_siteforISO/IEC DIR IEC SUP) since combining the two dependency trees is network-dependent and unverified in CI here.