Add support for multiple -m flags in create and comment#150
Add support for multiple -m flags in create and comment#1500xheartcode wants to merge 1 commit intoremenoscodes:mainfrom
Conversation
git commit supports multiple -m flags to build multi-paragraph messages. git-issue-create and git-issue-comment now match this behavior: each additional -m appends a new paragraph separated by a blank line, so git issue create 'Bug title' -m 'Context' -m 'Steps to reproduce' produces a two-paragraph body. Single -m behavior is unchanged. Tests added for both commands. Closes remenoscodes#138
b4943de to
1cbf74b
Compare
|
force pushed, updated docs to 284 tests. |
remenoscodes
left a comment
There was a problem hiding this comment.
Clean implementation — mirrors git commit multi--m behavior correctly. The printf '%s\n\n%s' approach handles paragraph joining well, and single -m usage is unaffected.
Tests pass locally (all 204). CI didn't trigger — likely needs first-time contributor workflow approval in the Actions tab.
Minor note: commit message should use conventional commits format (feat: add support for multiple -m flags) when squash-merging.
LGTM ✓
remenoscodes
left a comment
There was a problem hiding this comment.
Implementation looks great — approved on the code side (tests pass, clean approach).
One change needed before merge: the commit message should follow Conventional Commits format, which this project requires for automated changelog generation:
feat: add support for multiple -m flags in create and comment
Currently it's:
Add support for multiple -m flags in create and comment
Just needs the feat: prefix. You can fix it with:
git commit --amend -m "feat: add support for multiple -m flags in create and comment"
git push --force-with-leaseOnce that's updated, this is ready to merge. Thanks!
git commitsupports multiple-mflags to build multi-paragraph messages.git issue createandgit issue commentnow match this behavior: each additional-mappends a new paragraph separated by a blank line.Single
-musage is unchanged. Changes are confined to the argument parsing loop in each script. Two tests added tot/test-issue.sh. Full suite: 284 passed, 0 failed.Closes #138