Skip to content

feat(ea-preview) - preview the pdf and download it#1085

Merged
gabrielseco merged 4 commits into
mainfrom
pbyr-4108-preview-pdf-on-the-sdk-full-screen
Jun 17, 2026
Merged

feat(ea-preview) - preview the pdf and download it#1085
gabrielseco merged 4 commits into
mainfrom
pbyr-4108-preview-pdf-on-the-sdk-full-screen

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

I've ask externally to see what partners have in mind to implement on this step, you can take a look at the loom and see how it looks and what questions I asked

Basically we call a new endpoint to get the preview pdf, we don't have the need to call a different endpoint to download the pdf as it already there.

I think most of the code should be implemented on the example app as they only need the pdf and then they bring their own components to preview the viewer etc...

and I don't know what UI they're going to use, that's why I asked some questions to them

When they clarify, I can modify or keep this solution

https://www.loom.com/share/2f157c2a75cf450580c948f7ad1513ce

Note

Low Risk
Read-only preview fetch and example/UI wiring; no changes to employment creation, signing, or auth flows.

Overview
Adds employment agreement preview data to onboarding when the ea_preview feature flag is enabled: a new useEmploymentAgreementPreview query loads the agreement from the API only on the employment_agreement_preview step, and the result is exposed on onboardingBag.employmentAgreementPreview (with loading folded into existing step loading state).

The example onboarding app turns on ea_preview and implements a full-screen dialog to open the PDF in an iframe (with a loading state) and download it via the existing downloadFile helper. The preview step component is unchanged aside from removing a stale comment.

Reviewed by Cursor Bugbot for commit 6db783e. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco gabrielseco self-assigned this Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 221.74 kB 221.62 kB +118 B (+0.1%) 🔴
Total (raw) 598.23 kB 597.29 kB +943 B (+0.2%) 🔴
CSS (gzip) 20.89 kB 20.89 kB 0 B (0%) 🟢
CSS (raw) 109.09 kB 109.09 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 221.74 kB / 250 kB (88.7%)
  • ✅ Total raw: 598.23 kB / 600 kB (99.7%)
  • ✅ CSS gzipped: 20.89 kB / 25 kB (83.5%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.44 kB (0 B (0%))
  3. index.css - 10.44 kB (0 B (0%))
  4. chunk-VDH46ZCF.js - 6.36 kB (new)
  5. index.js - 6.3 kB (-6 B (-0.1%))
View All Files (339 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.44 kB 0 B (0%)
index.css 10.44 kB 0 B (0%)
chunk-VDH46ZCF.js 6.36 kB new
index.js 6.3 kB -6 B (-0.1%)
chunk-GZUP2IE6.js 6.06 kB new
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-6HAWSFOM.js 4.76 kB new
chunk-QLVUYMGU.js 4.49 kB new
chunk-ZEC5X3RH.js 3.89 kB new

✅ Bundle size check passed

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2bfb2d8. Configure here.

Comment thread example/src/Onboarding.tsx Outdated
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 88.37% 88.35% +0.03% 🟢
Statements 87.78% 87.75% +0.03% 🟢
Functions 84.80% 84.77% +0.04% 🟢
Branches 79.68% 79.64% +0.04% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3823 / 4326
  • Coverage: 88.37%
  • Change: +0.03% (10 lines)
Statements Coverage
  • Covered: 3885 / 4426
  • Coverage: 87.78%
  • Change: +0.03% (10 statements)
Functions Coverage
  • Covered: 1038 / 1224
  • Coverage: 84.80%
  • Change: +0.04% (3 functions)
Branches Coverage
  • Covered: 2388 / 2997
  • Coverage: 79.68%
  • Change: +0.04% (10 branches)

✅ Coverage check passed

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-5q4u1dfv6-remotecom.vercel.app
Latest Commit:dc08541

Deployed with vercel-action

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-1pu7c3jhn-remotecom.vercel.app
Latest Commit:dc08541

Deployed with vercel-action

@gabrielseco gabrielseco merged commit ec89a8f into main Jun 17, 2026
11 checks passed
@gabrielseco gabrielseco deleted the pbyr-4108-preview-pdf-on-the-sdk-full-screen branch June 17, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants