Fix EC v3 extension helmCharts values: YAML map, not multi-line string#4269
Open
mikhailswift wants to merge 3 commits into
Open
Fix EC v3 extension helmCharts values: YAML map, not multi-line string#4269mikhailswift wants to merge 3 commits into
mikhailswift wants to merge 3 commits into
Conversation
In Embedded Cluster v3, extensions.helmCharts[].values must be nested
YAML (unmarshaled into map[string]any), unlike v2 where it was a
multi-line string. The v3 docs carried the v2 convention forward: the
field description said 'Multi-line string of Helm values' and every
example used a block scalar (values: |).
A release authored per these docs passes Vendor Portal lint and builds
air gap bundles, but fails at install time with 'cannot unmarshal !!str
into map[string]interface {}' when Embedded Cluster parses the
extension.
- Correct the values field description in embedded-config
- Add a requirement calling out that string values fail at install
- Change 'values: |' to 'values:' in all v3 extension examples
(embedded-config, embedded-using, embedded-v3-migrate,
template-functions)
unsupportedOverrides.builtInExtensions[].values and the v2 versioned
docs are unchanged: those are genuinely multi-line strings.
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AmberAlston
approved these changes
Jul 15, 2026
sgalsaleh
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In Embedded Cluster v3,
extensions.helmCharts[].valuesmust be nested YAML (it is unmarshaled intomap[string]any— seepkg/appcharts/appcharts.goHelmChartSpec.Values), unlike EC v2 where it was a multi-line string. The v3 docs carried the v2 convention forward:valuesfield description on /embedded-cluster/v3/embedded-config#helmcharts said "Multi-line string of Helm values"values: |)Why it matters
A release authored per the current docs passes Vendor Portal lint and airgap builds, but installation fails with
cannot unmarshal !!str into map[string]interface {}when Embedded Cluster parses the extension (reproduced end-to-end on a test app).Changes
valuesfield description inembedded-config.mdxvalues: |tovalues:in all v3 extension examples:embedded-config.mdx(3 examples),embedded-using.mdx(GPU operator),embedded-v3-migrate.mdx,template-functions.mdxDeliberately unchanged, verified against the EC v3 source:
unsupportedOverrides.builtInExtensions[].values— genuinely a multi-line string in v3 (pkg/addons/config.goasserts.(string))unsupportedOverrides.k0s— also a stringembedded-cluster_versioned_docs/version-2.0.0/) — v2's k0s-based schema really does use string valuesAll edited YAML examples were validated to parse with
valuesas a map, and the dryrun extension tests confirm template functions render correctly in map-form values.