Skip to content

getElementById and getSelection could return null #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 2 commits into from
Mar 18, 2026
Merged

getElementById and getSelection could return null #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5013d4
getElementById could return null
Freddy03h Mar 18, 2026
d9d2607
getSelection could return null
Freddy03h Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DOMAPI/Document.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Returns the first element within node's descendants whose ID is elementId.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/getElementById)
*/
@send
external getElementById: (document, string) => element = "getElementById"
external getElementById: (document, string) => null<element> = "getElementById"

/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/getAnimations)
Expand Down Expand Up @@ -442,7 +442,7 @@ Returns an object representing the current selection of the document that is loa
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/getSelection)
*/
@send
external getSelection: document => selection = "getSelection"
external getSelection: document => null<selection> = "getSelection"

/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Document/hasStorageAccess)
Expand Down
2 changes: 1 addition & 1 deletion src/DOMAPI/DocumentFragment.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Returns the first element within node's descendants whose ID is elementId.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/DocumentFragment/getElementById)
*/
@send
external getElementById: (T.t, string) => element = "getElementById"
external getElementById: (T.t, string) => null<element> = "getElementById"

/**
Inserts nodes before the first child of node, while replacing strings in nodes with equivalent Text nodes.
Expand Down
2 changes: 1 addition & 1 deletion src/DOMAPI/Window.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,4 +514,4 @@ external cancelIdleCallback: (window, int) => unit = "cancelIdleCallback"
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Window/getSelection)
*/
@send
external getSelection: window => selection = "getSelection"
external getSelection: window => null<selection> = "getSelection"
2 changes: 1 addition & 1 deletion src/Global.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,4 +744,4 @@ external cancelIdleCallback: int => unit = "cancelIdleCallback"
/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/Window/getSelection)
*/
external getSelection: unit => selection = "getSelection"
external getSelection: unit => null<selection> = "getSelection"